Add minimal settings profiles#60
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new "Profiles" settings pane that lets users save, apply, delete, import, and export reusable visual setups (click visuals, laser pointer, live shortcut display). Hotkeys, launch-at-login, menu layout, and activity history are intentionally not part of profiles.
Changes:
- New
ClickProfileStoreplusClickSettingsProfile/ClickProfileSettingsmodel that persists profiles toUserDefaultsand supports JSON import/export with a versioned envelope. - New
profilesPaneinClickLightSettingsView, a.profilescase inSettingsPane, and supporting save/apply/delete/export/import UI wiring. AppDelegateandSettingsWindowControllerplumb the newClickProfileStoreinto the settings view; several enums inSettingsStoregainCodableconformance so they can be serialized inside profiles.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/ClickLight/ClickProfileStore.swift | New profile model and ObservableObject store handling persistence, import, and export. |
| Sources/ClickLight/ClickLightSettingsView.swift | Adds the Profiles pane UI and import/export panels; registers the new SettingsPane case. |
| Sources/ClickLight/SettingsStore.swift | Adds Codable conformance to enums used by profile serialization. |
| Sources/ClickLight/SettingsWindowController.swift | Accepts ClickProfileStore and forwards it to the SwiftUI settings view; adds applyProfile on the view model. |
| Sources/ClickLight/AppDelegate.swift | Instantiates ClickProfileStore and passes it when constructing the settings window. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ae043a8 to
c722230
Compare
c722230 to
d7a8626
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
./build-app.sh.