Swift 6 upgrade to the repo #281
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wasn't this already done as part of #275? See: Package.swift: https://github.com/auth0/JWTDecode.swift/blob/master/Package.swift#L1 
JWTDecode.podspec: https://github.com/auth0/JWTDecode.swift/blob/master/JWTDecode.podspec#L22 
|
Widcket
reviewed
Jul 25, 2025
| @@ -410,7 +410,7 @@ class JWTDecodeSpec: XCTestCase { | |||
| } | |||
| } | |||
|
|
|||
| extension JWTDecodeError: @retroactive Equatable {} | |||
| extension JWTDecodeError: Equatable {} | |||
Widcket
reviewed
Jul 25, 2025
| C1896F0F2C1C731000CA1000 /* Quick.xcframework in Frameworks */, | ||
| C1896F0C2C1C730F00CA1000 /* Nimble.xcframework in Frameworks */, | ||
| C1896F0F2C1C731000CA1000 /* (null) in Frameworks */, | ||
| C1896F0C2C1C730F00CA1000 /* (null) in Frameworks */, |
There was a problem hiding this comment.
If you're removing Quick and Nimble, there should be no entries here.
Widcket
reviewed
Jul 25, 2025
| @@ -146,6 +146,7 @@ | |||
| isa = PBXFrameworksBuildPhase; | |||
| buildActionMask = 2147483647; | |||
| files = ( | |||
| D41DECE32DC89DE100F5B1A4 /* CwlPreconditionTesting in Frameworks */, | |||
There was a problem hiding this comment.
Please remove the CwlPreconditionTesting dependency as well (IIRC, it was added as an SPM dependency).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
PR has swift 6 changes in the repo and repo targets. this is a followup PR on Xcode 16 support in CI. #275
📎 References
🎯 Testing