-
Notifications
You must be signed in to change notification settings - Fork 169
feat: Exclude Third-Party Clients via AUTH0_EXCLUDE_THIRD_PARTY_CLIENTS config property
#1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for submitting this PR! Your contribution is greatly appreciated. We'll review it shortly |
|
Hi, @mgyarmathy Really appreciate your idea. 👍 The primary use of Deploy CLI is for "Infrastructure as Code." The source of truth is a static local file (YAML/JSON). Since the dynamic nature of DCR clients, it would be better to use the opposite approach, Thanks again, Great work on this PR! Thanks for taking the time to contribute. Let me know if you have any questions. Looking forward to your updates! |
If we implement the opposite behavior, we'd be introducing a breaking change, since currently third-party clients are included by default. Is this the direction you'd like to take this? |
|
Agree, this is a good candidate for v9.X.X. For v8 |
|
Hi, @mgyarmathy, I’ll take care of the failing CI check |
|
Hi, @mgyarmathy, |
468df88 to
a24f6a9
Compare
ba50fbe
4191f94 to
c565e20
Compare
c565e20 to
2fda27b
Compare
@kushalshit27 apologies -- I've signed all of the commits. Can you re-add the new e2e recordings before merging? |
|
Sure 👍 |
🔧 Changes
When Dynamic Client Registration (DCR) is enabled on a tenant, it can often have an innumerable amount of third-party clients that don't need to be directly managed through a tool like
auth0-deploy-cli.This PR adds a new
AUTH0_EXCLUDE_THIRD_PARTY_CLIENTSconfig property that enables the CLI to filter out third-party clients using the Client API'sis_first_partyrequest parameter.🔬 Testing
I've added a simple unit test and confirmed this works as expected on my own tenant (which includes third-party clients created via DCR), but would welcome the assistance of this project's maintainers to add E2E test recordings from the
deploy-cli-devorauth0-deploy-cli-e2etenant to further validate this new feature.📝 Checklist