Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for email verification_method in ConnectionOptions #792

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

kailash-b
Copy link
Contributor

@kailash-b kailash-b commented Mar 17, 2025

Changes

References

Testing

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@kailash-b kailash-b requested a review from a team as a code owner March 17, 2025 09:23
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.75%. Comparing base (23009d0) to head (40cfa44).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #792       +/-   ##
===========================================
+ Coverage   28.97%   72.75%   +43.77%     
===========================================
  Files         426      426               
  Lines        5511     5512        +1     
  Branches      364      364               
===========================================
+ Hits         1597     4010     +2413     
+ Misses       3848     1335     -2513     
- Partials       66      167      +101     
Flag Coverage Δ
authIntTests 28.79% <100.00%> (+1.13%) ⬆️
mgmtIntTests 58.56% <100.00%> (?)
unittests 3.97% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

nandan-bhat
nandan-bhat previously approved these changes Mar 17, 2025
@kailash-b kailash-b merged commit 4908b4b into master Mar 17, 2025
13 checks passed
@kailash-b kailash-b deleted the feature/SDK-5795 branch March 17, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants