fix: Remove unsafe type assertion in withPageAuthRequired HOC

[tusharpandey13]

Improves type safety by replacing unsafe as any cast with proper TypeScript type assertion in the withPageAuthRequired higher-order component.

Fixes: #2288

• All new/changed/fixed functionality is covered by tests (or N/A)
• I have added documentation for all new/changed functionality (or N/A)

🔍 RCA

The withPageAuthRequired HOC used an unsafe as any type assertion for prop spreading, which bypassed TypeScript's type checking and indicated potential type compatibility issues between generic constraints and component props.

📋 Changes

This change improves type safety without affecting runtime behavior. The HOC now uses proper TypeScript type assertions that maintain compile-time type checking while preserving the same functionality.

Changed src/client/helpers/with-page-auth-required.tsx: Replace unsafe as any cast with type-safe React.ComponentProps<typeof Component> assertion

📎 References

🎯 Testing

Automated:
All existing tests continue to pass (302/302 test suite). No new tests required as this is a type-level improvement without functional changes.

Manual:

1. Verify TypeScript compilation succeeds with npx tsc --noEmit
2. Build SDK with pnpm build
3. Test integration in sample app using yalc publish and yalc add @auth0/nextjs-auth0
4. Confirm withPageAuthRequired HOC functions identically to previous behavior

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.37%. Comparing base (fe1f5e7) to head (5d935bd).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2305      +/-   ##
==========================================
+ Coverage   85.34%   85.37%   +0.03%     
==========================================
  Files          26       26              
  Lines        2613     2619       +6     
  Branches      481      482       +1     
==========================================
+ Hits         2230     2236       +6     
  Misses        377      377              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[tusharpandey13]

@claude

[github-actions]

Claude finished @tusharpandey13's task —— View job

---

Code Review Complete ✅

Todo List:

• Read diff to understand changes
• Read project copilot instructions (not found, continuing)
• Analyze the modified file
• Create pending review
• Add review comments for any issues
• Submit final review assessment

Summary

Completed code review of PR #2305. The change successfully improves type safety by replacing unsafe as any with a more specific type assertion. Identified one area for potential further improvement regarding prop type conflicts, but overall this is a solid enhancement to the codebase's type safety.

---

[github-actions]

Overall Assessment

✅ This PR improves type safety by removing the unsafe as any cast

The change successfully replaces the problematic as any with a more specific type assertion. While there's still a minor type safety concern with potential prop conflicts, this is a significant improvement over the previous implementation. The change maintains the same runtime behavior while providing better TypeScript checking.