Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify watchResponse #135

Merged
merged 2 commits into from
Mar 20, 2025
Merged

modify watchResponse #135

merged 2 commits into from
Mar 20, 2025

Conversation

miparnisari
Copy link
Contributor

Amendment to #133

@miparnisari
Copy link
Contributor Author

miparnisari commented Mar 20, 2025

Hmm need to figure out how to bypass the breaking change check for something that hasn't been released 🤔 the check is not required to merge the PR

@vroldanbet
Copy link
Contributor

the check is not required to merge the PR

@miparnisari that linter error is legit: you've introduced a breaking protobuf change. However, because we know the previous change was never officially released, we can override that linter error. We should do that by using GitHub's ability to "bypass with admin privileges" button once approved.

Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miparnisari miparnisari merged commit 7144bbf into main Mar 20, 2025
2 of 3 checks passed
@miparnisari miparnisari deleted the modify-#133 branch March 20, 2025 20:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants