Repository navigation
Add a pull request template - #6
Merged
Merged
Conversation
Prompts for motivation, rejected approaches and provenance, and carries the repo's ship gate, regeneration and bronzethread coverage checks so they are visible at review time. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The repo has no pull request template. The checks that matter most at review time are spread through CLAUDE.md, so nothing puts them in front of an author when they open a PR. Those checks are: all three test suites passing, regenerating manifests and docs, and adding a bronzethread bundle for new behavior. The most expensive miss so far was a merge with only
mage test:unitgreen, which left the whole e2e suite broken. CLAUDE.md warns about exactly that.Summary of changes
Adds
.github/pull_request_template.md. It asks for motivation, a summary, rejected approaches and provenance (who or what wrote the change, and who read the diff). It also has checklists for the ship gate, regeneration, bronzethread and authz coverage, and a final check for scope and human review.Approaches rejected
Provenance
claude-opus-5-5)Ship gate
mage test:unitmage test:integrationmage test:e2eResults:
Regeneration
+kubebuilder:rbacmarker or CRD-shaping field changedconfig/**changedmage fmt:alluntilmage fmt:checkis clean. The new file passesoxfmt --check.mage fmt:checkstill fails overall becauseREADME.mdhas formatting issues that were already onmain; this PR leaves that file alone.Coverage
Before requesting review
🤖 Generated with Claude Code