Skip to content

Add a pull request template - #6

Merged
samkim merged 1 commit into
mainfrom
pr-template
Sep 28, 2026
Merged

samkim merged 1 commit into
mainfrom
pr-template

Conversation

@samkim

@samkim samkim commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

Motivation

The repo has no pull request template. The checks that matter most at review time are spread through CLAUDE.md, so nothing puts them in front of an author when they open a PR. Those checks are: all three test suites passing, regenerating manifests and docs, and adding a bronzethread bundle for new behavior. The most expensive miss so far was a merge with only mage test:unit green, which left the whole e2e suite broken. CLAUDE.md warns about exactly that.

Summary of changes

Adds .github/pull_request_template.md. It asks for motivation, a summary, rejected approaches and provenance (who or what wrote the change, and who read the diff). It also has checklists for the ship gate, regeneration, bronzethread and authz coverage, and a final check for scope and human review.

Approaches rejected

  • Linking to CLAUDE.md instead of repeating its checks. Authors skip a link. A checkbox in the description is visible to reviewers too.

Provenance

  • Author (person, or model and version): Claude Opus 5.5 (claude-opus-5-5)
  • Harness or tooling, with version: Claude Code 2.1.283
  • Person who read the diff: @samkim

Ship gate

  • mage test:unit
  • mage test:integration
  • mage test:e2e

Results:

Not run. The only change is a new Markdown file under .github/, and no Go
code, build tags or test fixtures are touched.

Regeneration

  • n/a: no +kubebuilder:rbac marker or CRD-shaping field changed
  • n/a: nothing under config/** changed
  • n/a: no cobra command or CRD schema changed
  • Ran mage fmt:all until mage fmt:check is clean. The new file passes oxfmt --check. mage fmt:check still fails overall because README.md has formatting issues that were already on main; this PR leaves that file alone.

Coverage

  • This adds no user-visible behavior
  • This touches none of authorization, the SpiceDB schema or the approver model

Before requesting review

  • The PR holds a single change.
  • A person has read every line of the diff.

🤖 Generated with Claude Code

Prompts for motivation, rejected approaches and provenance, and carries
the repo's ship gate, regeneration and bronzethread coverage checks so
they are visible at review time.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

@josephschorr josephschorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samkim
samkim merged commit 0780414 into main Sep 28, 2026
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants