feat: add --html flag for interactive permission trace visualization #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
==========================================
+ Coverage 39.28% 46.40% +7.12%
==========================================
Files 37 39 +2
Lines 5448 6340 +892
==========================================
+ Hits 2140 2942 +802
- Misses 3063 3109 +46
- Partials 245 289 +44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ivanauth
force-pushed
the
feature/html-explain-output
branch
4 times, most recently
from
ce98ec7 to
bc68ca9
Compare
Summary Adds --html and --html-output flags to zed permission check and zed permission check-bulk commands to generate interactive HTML visualizations of permission traces. Key Features TracePresentation helper: Shared presentation logic between HTML and console renderers for consistent icons and styling Self-contained output: Embedded CSS with VS Code Dark+ theme, automatic light mode, no external dependencies Memory pooling: Efficient bulk operations with sync.Pool pattern UI polish: Collapsible context, subject bullet icons, styled missing-context boxes, XSS protection Examples Examples in docs/html-examples/ covering simple, nested, caveated, and bulk scenarios. Test Plan go test ./internal/printers -v go test ./internal/commands -v
ivanauth
force-pushed
the
feature/html-explain-output
branch
from
bc68ca9 to
20fe462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds --html and --html-output flags to the zed permission check and zed permission check-bulk commands. These options generate interactive HTML visualizations of permission traces, making it easier to explore and share trace results.
Key Updates
TracePresentation helper – Shared logic between the HTML and console renderers to keep icons and styling consistent.
Self-contained output – Includes embedded CSS using the VS Code Dark+ theme (with auto light mode), no external assets required.
Memory pooling – Uses a sync.Pool for efficient memory reuse during bulk operations.
Examples
Added example outputs in docs/html-examples/ covering simple, nested, caveated, and bulk trace cases.