fix: close board and promotion review gaps - #2897
Merged
Merged
Conversation
Reject Unicode control, format and line/paragraph separators before trimming or forwarding titles, comments and block reasons to the CLI. Preserve normal Unicode text and UTF-8 limits, and remove the redundant post-trim check. Independent review SHIP; 28 plugin tests pass with 461 assertions, including 81 action/position rejection vectors that invoke no CLI command. The final aggregate gate follows the remaining validated promotion-review corrections. Co-authored-by: Felipe Rosa <felipe@namastex.ai>
Make tied board ordering explicit and bound smoke subprocesses. Require independent fix reviews and strengthen build and Host contract coverage. Co-authored-by: Felipe Rosa <felipe@namastex.ai>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Board actions now reject Unicode control and formatting characters before trimming or CLI execution. Equal-timestamp cards retain insertion order even when SQLite selects a different index.
This also bounds DSH smoke commands to 120 seconds, removes the coordinator self-review exception, and routes exhausted fix budgets through the existing diagnosis procedure. Build tests cover invalid-version failures and repeated output; Host tests require fixed attribution and environment values.
Addresses the six validated review findings on #2896. Both correction commits received independent review. Focused validation passed: 31 plugin/build tests, 76 board tests, 41 release-document tests, typecheck and lint. The original ordering query failed the alternate-index regression. A stalled direct child was killed at 120 seconds, and real DSH install/restart/authenticated operations/cleanup passed.
Full repository gate passed at eeafaea: 2,042 tests passed, 1 skipped, 0 failed, with 9,011 assertions. Four local candidate 5.260907.101 tarballs passed unsigned payload verification with extracted metadata and Host compatibility floors checked. The extracted Linux binary passed task/board and semantic roadmap dogfood. Parent real DSH 0.1.2-rc.1 install/restart/authenticated actions/cleanup passed. These are local packaging checks; stable publication remains a post-main human gate.
Tracks Genie Daily01, NMSTX-686. Targets dev so the existing human main-merge handoff #2896 receives the corrections.