[ci] Source shellcheck from nix instead of installing via script #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maru-ava
added
testing
ARR4N
approved these changes
Mar 18, 2025
There was a problem hiding this comment.
FYI there's a shellcheck action that avoids the indirection via a script.
| cp /tmp/shellcheck-"${VERSION}"/shellcheck "${SHELLCHECK}" | ||
| fi | ||
| fi | ||
|
|
||
| # `find *` is the simplest way to ensure find does not include a | ||
| # leading `.` in filenames it emits. A leading `.` will prevent the | ||
| # use of `git apply` to fix reported shellcheck issues. This is | ||
| # compatible with both macos and linux (unlike the use of -printf). | ||
| # | ||
| # shellcheck disable=SC2035 |
There was a problem hiding this comment.
It's shellcheck all the way down!
I'm aware, but an action doesn't solve the problem of local execution. Unless an action is performing something that makes no sense to perform outside of a github action runner, I always prefer a non-action solution that can be easily run locally. edit: And yes, I'm aware of https://github.com/nektos/act, but I think being able to run without that indirection is also preferable. |
StephenButtolph
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We're already using nix and it's simpler not to have to maintain a multi-platform installer.
How this works
How this was tested
CI
Need to be documented in RELEASES.md?
N/A