Add HttpClientFactory Capability to AvaTaxClient #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance we can get the conflicts resolved and this PR merged? I'm concerned about using this in a SaaS deployed environment with thousands of customers because with using "new HttpClient()" for every request in a backend API this could easily exhaust the socket pool in our environment. I would be happy to do another PR that simply allows the HttpClient to be injected if that would help. We would prefer not to fork the code and maintain it ourselves. |
|
@jusbuc2k I resolved the conflicts this morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In .Net Core and higher using the HttpClientFactory is the preferred method for managing HTTP Clients. https://docs.microsoft.com/en-us/aspnet/core/fundamentals/http-requests?view=aspnetcore-5.0#typed-clients
The PR includes 2 new public constructors that added the HttpClient parameter. An additional private parameterless constructor to initialize the static HttpClient, if one of the new HttpClient parameter constructors is not used.