Skip to content

Use strings for provides/requires #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Use strings for provides/requires #835

wants to merge 11 commits into from

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Jun 19, 2025 •
edited
Loading

This prevents issues where auto-provided/required types are not available during compilation or plugin activation.

  • Adds new default methods to the spi classes that will use strings for DI info
  • modify beanscope module ordering to use strings
  • add generic support for @InjectModule provides/requires (via string provides/requires)

resolves #834

@SentryMan SentryMan added this to the 11.6 milestone Jun 19, 2025
@SentryMan SentryMan requested a review from rbygrave June 19, 2025 19:53
@SentryMan SentryMan self-assigned this Jun 19, 2025
@SentryMan SentryMan added enhancement New feature or request refactor labels Jun 19, 2025
@SentryMan SentryMan enabled auto-merge June 19, 2025 19:53
@SentryMan SentryMan disabled auto-merge June 22, 2025 00:45
@SentryMan SentryMan enabled auto-merge (squash) June 22, 2025 00:45
@SentryMan SentryMan disabled auto-merge June 22, 2025 01:39
@SentryMan SentryMan enabled auto-merge (squash) June 22, 2025 02:47
@SentryMan SentryMan force-pushed the string-spi branch 2 times, most recently from 2944168 to 80ef6c5 Compare June 30, 2025 17:25
SentryMan added 6 commits July 1, 2025 20:22
@SentryMan
use strings for provides/requires
5edc776 
this prevents issues where auto provided/required types not available during compilation or plugin activation fail builds
@SentryMan
allow generics in @InjectModule
e56664e
@SentryMan
gradle
b2b2f72
@SentryMan
separate generics in generated annotation
8e52930
@SentryMan
Update AvajeModule.java
cceec07 
Revert "Update AvajeModule.java"

This reverts commit 87b41c2.

Update AvajeModule.java
@SentryMan
merge requires/provides
8643d5e 
there is no reason to split into three separate methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbygrave rbygrave Awaiting requested review from rbygrave

At least 1 approving review is required to merge this pull request.

Assignees

@SentryMan SentryMan

Labels
enhancement New feature or request refactor
Projects
None yet
Milestone
11.6
Development

Successfully merging this pull request may close these issues.

Task :blma-admin:blma-admin-web:compileJava FAILED
1 participant
@SentryMan