Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calendars for Iceland, India, Indonesia #176

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

pcatach
Copy link

@pcatach pcatach commented Jan 13, 2024

src/time/calendars/india.rs Fixed Show fixed Hide fixed
src/time/calendars/india.rs Fixed Show fixed Hide fixed
src/time/calendars/indonesia.rs Fixed Show fixed Hide fixed
src/time/calendars/indonesia.rs Fixed Show fixed Hide fixed
src/time/calendars/indonesia.rs Fixed Show fixed Hide fixed
src/time/calendars/indonesia.rs Fixed Show fixed Hide fixed
@avhz avhz merged commit 487d329 into avhz:main Jan 15, 2024
3 of 5 checks passed
@avhz
Copy link
Owner

avhz commented Jan 15, 2024

Awesome thank you for your effort for this ! I trust the dates are correct :)

@pcatach
Copy link
Author

pcatach commented Jan 15, 2024

Awesome thank you for your effort for this ! I trust the dates are correct :)

Yeah I got them for example from here: https://www.timeanddate.com/holidays/india/maha-shivaratri-shivaratri
it's really hard for non Gregorian calendar holidays as there's no general rule for converting unfortunately. I'd be curious to know how other people / companies approach this kind of problem, if they just hard code it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants