feat(cli): align find with AI Picks ranking - #15
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a74d3d1bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (query) { | ||
| parts.push(formatFindQueryArg(query)); | ||
| } | ||
| if (tag) { | ||
| parts.push(`--tag ${tag}`); |
There was a problem hiding this comment.
Escape pagination command arguments
When the original query or tag contains shell metacharacters, the Prev/Next hint is not safe to copy: formatFindQueryArg leaves single-word queries unquoted, and double quotes still allow expansions such as $() in bash. For example, a search invoked with a quoted query like foo;bar or foo $(cmd) can produce a pagination command that either runs a different command or executes command substitution when pasted, so the new navigation hint should shell-escape every user-derived argument.
Useful? React with 👍 / 👎.
| tag, | ||
| page, | ||
| limit, | ||
| sort: SEARCH_DEFAULT_SORT, |
There was a problem hiding this comment.
Don't request an unsupported sort key
For registries that implement the documented /api/v1/skills contract, this makes every askill find request use an unsupported sort value: the checked API spec still lists sort as only stars, updated, or name (docs/api-spec.md:47). Unless the server contract is updated everywhere before this CLI ships, these searches can be rejected or silently fall back to a different order despite the JSON claiming llm_score desc, so either update the API contract/server support or avoid sending this key.
Useful? React with 👍 / 👎.
|
Pushed follow-up commit Fixes:
Validation:
|
|
@codex review |
Summary
askill findrequest Registry AI Picks ordering by default viallm_score desc.find --jsonand document the default ordering.--tag/pagination behavior while adding--page=/--limit=support and Prev/Next hints.Validation
npm run buildnpm test(27 passed)test_find_json_output test_dashboard_json_contracts test_search(10 passed)Notes