fix(cli): select arm64 binary under Rosetta - #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
darwin-arm64on Apple Silicon even when the current shell or process reports x64.darwin-x64, and preserve existing Linux/Windows platform mapping.Why
Issue avibe-bot/avibe#552 reports
askillcrashing after a recent update on Apple Silicon when the x86_64 binary is installed under Rosetta. The direct failure mode is that process architecture is not the same as hardware architecture on translated macOS processes, so installer/upgrade logic can choose the wrong artifact.Validation
npm testnpm run builduname -m=x86_64andsysctl.proc_translated=1; installer selecteddarwin-arm64, downloaded an arm64 Mach-O binary, andaskill --versionreturned0.1.14.Notes
The existing
darwin-x64Bun artifact can still warn about AVX requirements under Rosetta. This PR prevents Apple Silicon/Rosetta users from receiving that x64 artifact in the first place. If we also want to support older Intel CPUs without AVX, that should be handled separately by publishing a baseline x64 build.