chore(agent): sync PR delivery policy - #21
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 638e5929c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| `background-watch-hook` is unavailable, install or enable it before starting | ||
| a review loop, or report the missing dependency as a blocker. |
There was a problem hiding this comment.
The repository-local and enabled skill sets contain no background-watch-hook, but these lines require agents to install or enable it—or stop as blocked—before beginning the review loop. Because AGENTS.md now mandates this delivery skill, including its review and close-out flow, every implementation task in the current environment becomes unable to complete once it reaches that stage. Ship or enable the dependency atomically with this policy, or make the missing watcher non-blocking.
AGENTS.md reference: AGENTS.md:L85-L88
Useful? React with 👍 / 👎.
| CI check set is present and fully successful, and | ||
| `gh pr view --json mergeStateStatus` == `CLEAN` — so that a check which | ||
| errors, returns empty, or omits an expected check reads as *do not merge*. | ||
| Then merge with `gh pr merge --match-head-commit <validated-head-sha>` — no |
There was a problem hiding this comment.
When an authorized merge targets an ordinary branch without a merge queue, this command does not specify --merge, --squash, or --rebase. The installed gh pr merge --help states that no strategy is required only for merge-queue branches; otherwise this invocation asks What merge method would you like to use?, so an asynchronous/non-TTY agent can fail or stall after successfully passing every gate. Include the repository's intended strategy in the guarded command.
AGENTS.md reference: AGENTS.md:L85-L88
Useful? React with 👍 / 👎.
1 participant
Summary
pr-delivery-looppolicy from chore(agent): separate PR policy from background watchers avibe#1285background-watch-hookskill instead of bundling scripts hereAGENTS.mdrequire the policy by skill name onlyScope
Evidence
6e0ac9d9d4af9209be22d326d3e1aef1c799766fd7804f6a4525f04d5ce830778a930280bf40cd5e27b8fd2dae7600067f82197dSKILL.md; no waiter implementation was copiedgit diff --checkpasses