Skip to content

fix(ui): streamline mobile Show Page navigation - #1619

Merged
cyhhao merged 3 commits into
masterfrom
fix/mobile-app-window
Aug 21, 2026
Merged

fix(ui): streamline mobile Show Page navigation#1619
cyhhao merged 3 commits into
masterfrom
fix/mobile-app-window

Conversation

@cyhhao

@cyhhao cyhhao commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve literal /show/:sessionId/ document navigation when an installed mobile PWA opens an Agent-provided Show Page link.
  • Give the mobile Show Page app the full viewport with no AppShell side padding, brand header, or bottom navigation.
  • Replace the old framed app header with the compact chat-style back/title/annotation bar.

Evidence

  • Unit/component: 42 focused Vitest cases passed, including PWA routing, AppShell chrome, and the mobile Show Page header.
  • Static/build: UI lint baseline and production build passed.
  • Scenario: local Incus worktree regression at 390x844 confirmed a 390px-wide shell and iframe, 49px header, two controls, and no duplicate brand or bottom chrome.
  • Residual manual check: physical iOS installed-PWA link interception remains for the integration acceptance pass.

Scenario IDs: none (no matching catalog entry).

Dependencies: none.

Known-by-design ledger: none.

@cyhhao

cyhhao commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a790007b4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui/src/components/apps/ShowPageRoute.tsx Outdated
Comment thread ui/src/components/apps/ShowPageRoute.tsx Outdated
@cyhhao

cyhhao commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 7429357571

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cyhhao
cyhhao merged commit 2bbfb1e into master Aug 21, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant