refactor(show-access): retire legacy Show Page email authorization - #1649
Open
cyhhao wants to merge 1 commit into
Open
refactor(show-access): retire legacy Show Page email authorization#1649cyhhao wants to merge 1 commit into
cyhhao wants to merge 1 commit into
Conversation
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1498
Contract
Keep
/padmission single-axis and local: ShowAccess owns private/limited/public plus email/group/organization whitelist matching. Backend supplies only verified identity and optional organization claims./showis gated by Instance role; a Limited guest lease is read-only and cannot reach HMR or annotation capability.Changes
show_page_emailInstance source, page-scoped claims, OAuth scope/gate/compatibility branches, and old scenario harness/tests./showviewer/editor boundaries role-only and keep guestcanAnnotatefalse.The inventory found no current
/pconsumer of hosted authorized-emails,remote_access_show_page_email_grants, or backendshow_page_emailOIDC flow. Generic resource-syncshow_pagecode remains outside this retired hosted model because it has no current/pconsumer.Validation
getSigner().signVerifiedIdentityAssertionRS256 JWT with non-ASCII subject/organization/member/group claims was verified by Avibe through a local JWKS server, admitted into Limited/pby a group lease, denied/show, and returnedcanAnnotate:false.Cross-repo order
This PR is independent (not stacked). Recommended order is merge and deploy the backend PR first, then merge and deploy this Avibe PR. Do not merge either PR as part of this change.