Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add options_for_filter method to BadgeField #3710

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Mar 3, 2025

Description

Fixes https://github.com/avo-hq/avo-dynamic_filters/issues/82

Dynamic filters will now pick the correct options from badge fields.

    field :stage, as: :badge, options: {info: ["Discovery", "Idea"], success: "Done", warning: "On hold", danger: "Cancelled"}, filterable: true

image

Notice that neutral is an option since it is one of the default options.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob self-assigned this Mar 3, 2025
@github-actions github-actions bot added the Fix label Mar 3, 2025
Copy link

codeclimate bot commented Mar 3, 2025

Code Climate has analyzed commit d3d939e and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit a799ac4 into main Mar 3, 2025
21 checks passed
@Paul-Bob Paul-Bob deleted the fix/badge_filter_options branch March 3, 2025 12:13
Copy link
Contributor

github-actions bot commented Mar 3, 2025

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant