Skip to content

utils_net: enable host interface setting for ovs bridge #4280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nanli1 merged 2 commits into from
Jan 22, 2026
Merged

utils_net: enable host interface setting for ovs bridge #4280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71abb4a
utils_net: enable host interface setting for ovs bridge
smitterl Dec 9, 2025
30e143a
utils_net: add error handling for host interface setting
smitterl Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions virttest/utils_net.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4612,7 +4612,7 @@ def get_netkvm_param_value(vm, param, nic_index=0):


def create_ovs_bridge(
ovs_bridge_name, session=None, ignore_status=False, ip_options=""
ovs_bridge_name, session=None, ignore_status=False, ip_options="", iface_name=None
):
"""
Create ovs bridge via tmux command on local or remote
Expand All @@ -4621,6 +4621,7 @@ def create_ovs_bridge(
:param session: The remote session
:param ignore_status: Whether to raise an exception when command fails
:param ip_options: ip command options
:param iface_name: if given use this interface instead of discovering
:return: The command status and output
"""
runner = process.run
Expand All @@ -4632,7 +4633,13 @@ def create_ovs_bridge(
runner = local_runner
if session:
runner = session.cmd
iface_name = get_net_if(runner=runner, state="UP", ip_options=ip_options)[0]
if not iface_name:
up_ifaces = get_net_if(runner=runner, state="UP", ip_options=ip_options)
if not up_ifaces:
raise exceptions.TestError(
"No network interfaces in UP state found for bridge creation"
)
iface_name = up_ifaces[0]
Comment thread
coderabbitai[bot] marked this conversation as resolved.
if not utils_package.package_install(["tmux", "dhcp-client"], session):
raise exceptions.TestError("Failed to install the required packages.")

Expand Down Expand Up @@ -4660,7 +4667,7 @@ def create_ovs_bridge(


def delete_ovs_bridge(
ovs_bridge_name, session=None, ignore_status=False, ip_options=""
ovs_bridge_name, session=None, ignore_status=False, ip_options="", iface_name=None
):
"""
Delete ovs bridge via tmux command on local or remote
Expand All @@ -4669,6 +4676,7 @@ def delete_ovs_bridge(
:param session: The remote session
:param ignore_status: Whether to raise an exception when command fails
:param ip_options: ip command options
:param iface_name: if given use this interface instead of discovering
:return: The command status and output
"""
runner = process.run
Expand All @@ -4680,7 +4688,13 @@ def delete_ovs_bridge(
runner = local_runner
if session:
runner = session.cmd
iface_name = get_net_if(runner=runner, state="UP", ip_options=ip_options)[0]
if not iface_name:
up_ifaces = get_net_if(runner=runner, state="UP", ip_options=ip_options)
if not up_ifaces:
raise exceptions.TestError(
"No network interfaces in UP state found for bridge deletion"
)
iface_name = up_ifaces[0]
if not utils_package.package_install(["tmux", "dhcp-client"], session):
raise exceptions.TestError("Failed to install the required packages.")

Expand Down
Loading