Adding features and fixing SQL connection #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mindless999
commented
May 9, 2023
Mindless999
commented
- Added feature to check if module is installed and otherwise automatically install it if agreed by the user
- Added feature to check if running as Administrator, because of connection to the SQL server
- Fixed not able to connect using newer versions of invoke-sqlcmd requiring encrypted connection by default
Invoke-Sqlcmd by default now requires mandatory Encryption. On local WSUS databases by default this is still unencrypted. Allowing for the Encryption to be optional
Checking if SqlServer powershell module is installed, and asks to be installed if not. Stops script if declined
Checking if running as Administrator due to required Administrator privileges when connecting to the database
|
This script is nice but crippled without editing the Invoke-sqlcmd encryption. |
|
This should really be merged, as these 3 corrections are improving and required for some people, like me ;-) |
|
Just wanted to comment since the author hasn't merged these requests. The first one is the main one and it's easy enough to manually edit the script and add the " -Encrypt Optional" to the two lines. The second two items are nice to have but easy to get around. I agree they should be merged but if you are having this issue you can fix it yourself for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.