Collection & Morphable pivot table support #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Components/Tables/CuratorColumn.php # src/helpers.php
|
Thanks for the hard work. I will get this tested as soon as I can. |
|
Any update on this? ie, my review questions? |
|
What questions? |
|
@awcodes I could be wrong here, but there is no review on this PR. At least I can't see your questions |
awcodes
reviewed
Feb 19, 2025
| 'image_crop_aspect_ratio' => null, | ||
| 'image_resize_mode' => null, | ||
| 'image_resize_target_height' => null, | ||
| 'image_resize_target_width' => null, |
|
Apparently I missed the finish review button. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a rework of the previous PR, and a fix on issue #529 a fix has been implemented, now supporting pivot morphable table and collections in the pivot table.
in order to use the pivot table users can now set the pivot model in the config file on the key 'intermediate_model', and its value should be the intermediate model class, i.e. MediaItem::class;
The previous got solved. We do not use get_class() anymore, so it cannot be called with integer arguements. Instead a comparisson of types is now used, where we compare the type of the intermediate model set in the config file, and the actual Media class that we fetch from the database.