Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO Keycloak #418

Merged
merged 1 commit into from
Nov 4, 2022
Merged

SSO Keycloak #418

merged 1 commit into from
Nov 4, 2022

Conversation

darkdragon-001
Copy link
Contributor

Thank you for taking the time to work on a PR for Awesome-Sysadmin!

To ensure your PR is dealt with swiftly please check the following:

  • Your additions are Free software
  • Software your are submitting is not your own, unless you have a healthy ecosystem with a few contributors (which aren't your sock puppet accounts).
  • Submit one item per pull request. This eases reviewing and speeds up inclusion.
  • Format your submission as follows, where Demo and Clients are optional.
    Do not add a duplicate Source code link if it is the same as the main link.
    Keep the short description under 80 characters and use sentence case
    for it, even if the project's webpage or readme uses another capitalisation.
    Demo links should only be used for interactive demos, i.e. not video demonstrations.
    - [Name](http://homepage/) - Short description, under 250 characters, sentence case. ([Demo](http://url.to/demo), [Source Code](http://url.of/source/code), [Clients](https://url.to/list/of/related/clients-or-apps)) `License` `Language`
  • Additions are inserted preserving alphabetical order.
  • Additions are not already listed at awesome-selfhosted
  • The Language tag is the main server-side requirement for the software. Don't include frameworks or specific dialects.
  • You have searched the repository for any relevant issues or PRs, including closed ones.
  • Any category you are creating has the minimum requirement of 3 items (see Add SSO services #409)
  • Any software project you are adding to the list is actively maintained.
  • The pull request title is informative, unlike "Update README.md".
    Suggested titles: "Add aaa to bbb" for adding software aaa to section bbb,
    "Remove aaa from bbb" for removing, "Fix license for aaa", etc.

Why it is awesome

This provider is so awesome because it allows you to maintain a single account but provide many independent services.

@fbartels
Copy link

It is probably easier to put the change from this pr and #419 and #420 in a single pr. As soon as one of them is merged there will be a merge conflict in the other two prs that would need fixing/rebase.

@darkdragon-001
Copy link
Contributor Author

@fbartels That's what I did in #409 which was closed with the request to split it up into separate MRs...

@fbartels
Copy link

Ah, i missed that ticket.

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@nodiscc nodiscc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@darkdragon-001
Copy link
Contributor Author

darkdragon-001 commented Oct 21, 2022

I noticed you were missing the closing mark in your suggestion and only added the opening one.

@darkdragon-001
Copy link
Contributor Author

I fixed it.

@nodiscc nodiscc merged commit 8b4c80f into awesome-foss:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants