Skip to content

fix(liveness): Prevent crash on detachPreviewSurface is context is null #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(liveness): Prevent crash on detachPreviewSurface is context is null #255

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b99d1b9
Prevent crash on detachPreviewSurface is context is null
tylerjroach Aug 6, 2025
6a9e24a
Merge branch 'main' into tjroach/fix-edgecase-surface-crash
mattcreaser Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion liveness/src/main/java/com/amplifyframework/ui/liveness/camera/OpenGLRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,11 @@ public ListenableFuture<Void> detachPreviewSurface() {
mExecutor.execute(
() -> {
if (!mIsShutdown) {
setWindowSurface(mAdditionalContext, null);
if (mAdditionalContext != 0) {
setWindowSurface(mAdditionalContext, null);
} else if (DEBUG) {
Log.d(TAG, "!!! mAdditionalContext null during detachPreviewSurface");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the impact of this value being 0? Should this log be at a higher level?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This files a bit weird as far as logging goes. All logs are debug level and the DEBUG flag can only be set at development. This is primarily because liveness doesn't have a logger that can be used.

As far as mAdditionalContext being 0. Its initial value is 0. The value is supposed to be set when attachPreviewSurface is called. It appears that that has failed and the value is never set when the surface is destroyed.

This is an edge case failure by what appears to be a manufacturer/hardware bug based on reports. The liveness challenge is likely to fail because it appears the surface isn't getting set properly. But this should hopefully allow the liveness flow to present an onError failure rather than an app force close.

}
mAdditionalTransformation.mSurfaceSize = null;
}
completer.set(null);
Expand Down