Skip to content

Conversation

osama-rizk
Copy link
Contributor

@osama-rizk osama-rizk commented Aug 31, 2025

Description of changes

Since we are using mocked data with no actual bucket in the storage browser, the file preview will always return an error. To avoid this, the getUrl function will be mocked.

Description of how you validated changes

  • run the docs locally.

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@osama-rizk osama-rizk requested a review from a team as a code owner August 31, 2025 23:15
Copy link

changeset-bot bot commented Aug 31, 2025

⚠️ No Changeset found

Latest commit: cd9de51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@osama-rizk osama-rizk merged commit b4f5b9b into storage-browser/object-preview Sep 1, 2025
@osama-rizk osama-rizk deleted the storage-browser/object-preview-docs-mock-preview branch September 1, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants