Update needs more stabilize for VPC endpoints #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a well known Maven technique to simplify managing versions in a package with submodules. Most of the plugins and dependencies are placed in the top level pom.xml and versions can be managed either with dependencyManagement or properties where needed. The RPDK plugin needs to be executed in the context of the module it is working for so we could not consolidate that too at the top pom.xml.
We learned that there are multiple cases where VPC endpoint might be in transitional state and the Contract Test failures have consistently pointed to the DeleteServer happening too soon adter a server update. This change removes the shotcut in the stabilize process and forces all code paths to go though the isVpcEndpointAvailable code path.
Alex-Vol-Amz
force-pushed
the
fix-update-stabilize
branch
from
406c260 to
5e8602c
Compare
kevin-sellers
approved these changes
Jul 8, 2024
lydakis
approved these changes
Jul 8, 2024
aws-sde
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We learned that there are multiple cases where VPC endpoint might be in transitional state and the Contract Test failures have consistently pointed to the DeleteServer happening too soon adter a server update.
This change removes the shotcut in the stabilize process and forces all code paths to go though the isVpcEndpointAvailable code path.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.