Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors with self service tests #67

Conversation

Alex-Vol-Amz
Copy link
Contributor

Description of changes:

This is on top of the previous PR so it includes the commit from the same. It should be reviewed only for the contents of the related commit.

The changes were corrections that addressed differences with the original self-service implementation and discovered by running integration tests against the Uluru resources.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Alex-Vol-Amz Alex-Vol-Amz force-pushed the fix-errors-with-self-service-tests branch 2 times, most recently from 0c065da to a8b93db Compare July 1, 2024 16:22
The self-service integration tests revealed that the handlers had
mistakes and needs corrections. These are all the changes necessary to
pass self-service integration tests fully when running against Uluru
resources.
@Alex-Vol-Amz Alex-Vol-Amz force-pushed the fix-errors-with-self-service-tests branch from a8b93db to 0206a0e Compare July 8, 2024 17:43
@Alex-Vol-Amz Alex-Vol-Amz merged commit fcf83fe into aws-cloudformation:main Jul 8, 2024
8 checks passed
@Alex-Vol-Amz Alex-Vol-Amz deleted the fix-errors-with-self-service-tests branch July 8, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants