-
Notifications
You must be signed in to change notification settings - Fork 206
fix: ensure maps of enums are generated properly #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure maps of enums are generated properly #586
Conversation
e782d8d
to
953d030
Compare
/test s3-controller-test |
/test s3-controller-test |
can we have a description of the issue, small snippets from glue? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test dynamodb-controller-test |
@michaelhtm: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test dynamodb-controller-test |
/test ec2-controller-test |
1 similar comment
/test ec2-controller-test |
016d4c5
into
aws-controllers-k8s:main
Description of changes:
Currently, generating Maps of Enums was error prone. Instead of generating them.
With these changes, we ensure map[string]Enum are generated properly.
Sample:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.