fix(helm): avoid null volumes in deployment

[blanchardma]

Description of changes:

The AWS ACK Helm chart generates "volumes": null when no static secret .Values.aws.credentials.secretName or no extra volume .Values.deployment.extraVolumes was set. This can cause issues during the deployment, particularly with admission controllers such as policy engines. An example issue can be found here kyverno/policies#1310 by Kyverno.

This PR solves such problems without using a workaround, like deploying an unused emptyDir.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[ack-prow]

Hi @blanchardma. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[a-hilaly]

/ok-to-test

[a-hilaly]

Makes sense to me, thanks @blanchardma !

[ack-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, blanchardma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [a-hilaly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[a-hilaly]

/ok-to-test

[a-hilaly]

cc @michaelhtm @knottnt @rushmash91

[knottnt]

volumeMounts has a similar pattern. Should it also be omitted when .Values.aws.credentials.secretName and .Values.deployment.extraVolumeMounts are not set?

[blanchardma]

Good point, I already integrated it into the commit.

[ack-prow]

@blanchardma: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
verify-attribution	fad326f	link	false	/test verify-attribution
s3-olm-test	fad326f	link	false	/test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.