Skip to content

Respect GOARCH value in build-controller-image.sh #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

knottnt
Copy link
Contributor

@knottnt knottnt commented Jul 23, 2025

Issue #2568

Description of changes:

  • Fix incorrect usage of non-existent go_arch build arg
  • Add --platform flag based on value of GOARCH

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Fix incorrect usage of non-existent go_arch build arg

- Add --platform flag based on value of GOARCH
Copy link

ack-prow bot commented Jul 23, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2025
@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm July 23, 2025 20:51
@ack-prow ack-prow bot added the approved label Jul 23, 2025
@knottnt
Copy link
Contributor Author

knottnt commented Jul 23, 2025

/test all

@knottnt knottnt marked this pull request as ready for review July 23, 2025 21:38
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2025
@ack-prow ack-prow bot requested a review from rushmash91 July 23, 2025 21:38
@a-hilaly
Copy link
Member

/lgtm
/retest

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2025
Copy link

ack-prow bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ack-prow bot commented Jul 24, 2025

@knottnt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 856186d link false /test verify-attribution
s3-olm-test 856186d link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-prow ack-prow bot merged commit 2122428 into aws-controllers-k8s:main Jul 24, 2025
17 of 19 checks passed
@knottnt knottnt deleted the use-target-arch branch July 25, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants