Skip to content

Add serverlesscache to elasticache #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 23, 2025
Merged

Add serverlesscache to elasticache #175

merged 6 commits into from
Jul 23, 2025

Conversation

rushmash91
Copy link
Member

@rushmash91 rushmash91 commented Jul 17, 2025 •
edited
Loading

fixes aws-controllers-k8s/community#2522

Description of changes:

  • Add support serverlesscache resource

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler July 17, 2025 22:03
@ack-prow ack-prow bot added the approved label Jul 17, 2025
@rushmash91 rushmash91 force-pushed the elasticache-add-serverlesscache branch from 4e8c424 to 23bb928 Compare July 17, 2025 22:57
@rushmash91 rushmash91 force-pushed the elasticache-add-serverlesscache branch from fc9cbc6 to 667b5c5 Compare July 17, 2025 23:51
@rushmash91
Copy link
Member Author

/test elasticache-kind-e2e

@rushmash91 rushmash91 force-pushed the elasticache-add-serverlesscache branch 4 times, most recently from 1f5cf20 to 61ea0e8 Compare July 18, 2025 07:48
@rushmash91
Copy link
Member Author

unrelated test..
/test elasticache-kind-e2e

@rushmash91 rushmash91 force-pushed the elasticache-add-serverlesscache branch from 61ea0e8 to 767653a Compare July 21, 2025 17:27
michaelhtm
michaelhtm reviewed Jul 21, 2025
View reviewed changes
@rushmash91 rushmash91 force-pushed the elasticache-add-serverlesscache branch 2 times, most recently from c18af55 to 9124f38 Compare July 23, 2025 00:51
@rushmash91 rushmash91 force-pushed the elasticache-add-serverlesscache branch from 9124f38 to 1527425 Compare July 23, 2025 02:21
@ack-prow ACK Prow
Copy link

ack-prow bot commented Jul 23, 2025 •
edited
Loading

@rushmash91: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
elasticache-verify-attribution 44b47ca link false /test elasticache-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

michaelhtm
michaelhtm approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Jul 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michaelhtm,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 53eaf3a into aws-controllers-k8s:main Jul 23, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelhtm michaelhtm michaelhtm approved these changes

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

@jlbutler jlbutler Awaiting requested review from jlbutler

Assignees

@michaelhtm michaelhtm

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Resource] Elasticache Controller
3 participants
@rushmash91 @michaelhtm @ack-test-agent