Skip to content

feat: Add support for Collection resource #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

feat: Add support for Collection resource #2

merged 2 commits into from
Jul 14, 2025

Conversation

michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented May 15, 2025 •
edited
Loading

Issue #2211

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and knottnt May 15, 2025 20:54
@ack-prow ack-prow bot added the approved label May 15, 2025
@michaelhtm michaelhtm force-pushed the feat/addcollectionsupport branch 3 times, most recently from 90dc642 to 9278de2 Compare May 15, 2025 21:58
knottnt
knottnt approved these changes May 16, 2025
View reviewed changes
Copy link

@knottnt knottnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit.

@a-hilaly
Copy link
Member

a-hilaly commented Jul 2, 2025

@michaelhtm can you please rebase and ship this one?

@michaelhtm michaelhtm force-pushed the feat/addcollectionsupport branch 5 times, most recently from 845224b to accabd4 Compare July 3, 2025 01:37
@michaelhtm
Copy link
Member Author

@a-hilaly rebased PR, it should be ready for review now!

knottnt
knottnt reviewed Jul 3, 2025
View reviewed changes
@michaelhtm michaelhtm force-pushed the feat/addcollectionsupport branch from accabd4 to 20d8807 Compare July 9, 2025 23:48
@knottnt
Copy link

knottnt commented Jul 10, 2025

/retest

@michaelhtm michaelhtm force-pushed the feat/addcollectionsupport branch 3 times, most recently from 88579de to 2a1b5e6 Compare July 10, 2025 22:46
knottnt
knottnt reviewed Jul 10, 2025
View reviewed changes
config/crd/bases/opensearchserverless.services.k8s.aws_collections.yaml Outdated
type: string
type: object
type: array
type_:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this still has a trailing underscore.

a-hilaly
a-hilaly approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!
+1 to trevor's comment for the type_ field

@michaelhtm michaelhtm force-pushed the feat/addcollectionsupport branch from 2a1b5e6 to ad969a7 Compare July 14, 2025 18:25
@michaelhtm
Copy link
Member Author

@a-hilaly addressed comment!

@ack-prow ACK Prow
Copy link

ack-prow bot commented Jul 14, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
opensearchserverless-verify-attribution ad969a7 link false /test opensearchserverless-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

a-hilaly
a-hilaly approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Jul 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,knottnt,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 0c31691 into aws-controllers-k8s:main Jul 14, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knottnt knottnt knottnt approved these changes

@a-hilaly a-hilaly a-hilaly approved these changes

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelhtm @a-hilaly @knottnt