fix: Set missing fields during update cluster configuration #89
Conversation
michaelhtm
force-pushed
the
fix/setresourcesandwait
branch
6 times, most recently
from
1173b5f to
0304444
Compare
|
/retest |
michaelhtm
force-pushed
the
fix/setresourcesandwait
branch
from
0304444 to
69f014a
Compare
pkg/resource/domain/hooks.go
Outdated
| } | ||
|
|
||
| func isAutoTuneOptionAvailable(autoTuneOption *svcapitypes.AutoTuneOptionsInput) bool { | ||
| if autoTuneOption == nil { |
There was a problem hiding this comment.
Q: What is meant by "Available" here? It seems odd that something would be considered available when something is nil or disabled.
There was a problem hiding this comment.
this function is just another form of isAutoTuneOptionReady which accepts the svcsdktypes.AutotuneOptionsOutput.
There was a problem hiding this comment.
Is this more of an overload of isAutoTuneOptionReady where the semantic meaning is the same or does it mean something different for AutoTune to be available vs ready?
There was a problem hiding this comment.
There's no difference really. Just needed to use it with different structs. removing isAutoTuneOptionAvailable to avoid confusion.
michaelhtm
force-pushed
the
fix/setresourcesandwait
branch
2 times, most recently
from
43b1cf9 to
e69ba89
Compare
|
/test opensearchservice-kind-e2e |
1 similar comment
|
/test opensearchservice-kind-e2e |
michaelhtm
force-pushed
the
fix/setresourcesandwait
branch
from
e69ba89 to
c29f212
Compare
michaelhtm
changed the title
Co-Authored-By: Andrei Charviakou <[email protected]>
michaelhtm
force-pushed
the
fix/setresourcesandwait
branch
from
c29f212 to
0a1fb39
Compare
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #2219
Description of changes:
Set missing fields during domain update operation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.