Skip to content

Commit

Permalink
reduces verbosity for featuregate names
Browse files Browse the repository at this point in the history
  • Loading branch information
TiberiuGC committed Aug 8, 2024
1 parent 59c445a commit 88a1c3f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions pkg/featuregate/features.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@
package featuregate

const (
// FeatureCARMv2 is the name of the CARMv2 feature.
FeatureCARMv2 = "CARMv2"
// CARMv2 is the name of the CARMv2 feature.
CARMv2 = "CARMv2"
)

// defaultACKFeatureGates is a map of feature names to Feature structs
// representing the default feature gates for ACK controllers.
var defaultACKFeatureGates = FeatureGates{
// Set feature gates here
FeatureCARMv2: {Stage: Alpha, Enabled: false},
CARMv2: {Stage: Alpha, Enabled: false},
}

// FeatureStage represents the development stage of a feature.
Expand Down
2 changes: 1 addition & 1 deletion pkg/runtime/adoption_reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func (r *adoptionReconciler) reconcile(ctx context.Context, req ctrlrt.Request)
acctID, needCARMLookup := r.getOwnerAccountID(res)

var roleARN ackv1alpha1.AWSResourceName
if r.cfg.FeatureGates.IsEnabled(featuregate.FeatureCARMv2) {
if r.cfg.FeatureGates.IsEnabled(featuregate.CARMv2) {
teamID := r.getTeamID(res)
if teamID != "" {
// The user is specifying a namespace that is annotated with a team ID.
Expand Down
2 changes: 1 addition & 1 deletion pkg/runtime/reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ func (r *resourceReconciler) Reconcile(ctx context.Context, req ctrlrt.Request)
acctID, needCARMLookup := r.getOwnerAccountID(desired)

var roleARN ackv1alpha1.AWSResourceName
if r.cfg.FeatureGates.IsEnabled(featuregate.FeatureCARMv2) {
if r.cfg.FeatureGates.IsEnabled(featuregate.CARMv2) {
teamID := r.getTeamID(desired)
if teamID != "" {
// The user is specifying a namespace that is annotated with a team ID.
Expand Down

0 comments on commit 88a1c3f

Please sign in to comment.