chore: Upgrade aws-sdk-go-v2 from 1.32 to 1.39 #326
Conversation
|
Skipping CI for Draft Pull Request. |
ack-prow
bot
added
do-not-merge/work-in-progress
sirutBuasai
changed the title
| if r.ko.Spec.DomainSettings.TrustedIdentityPropagationSettings != nil { | ||
| f5f4 := &svcsdktypes.TrustedIdentityPropagationSettings{} | ||
| if r.ko.Spec.DomainSettings.TrustedIdentityPropagationSettings.Status != nil { | ||
| f5f4.Status = svcsdktypes.FeatureStatus(*r.ko.Spec.DomainSettings.TrustedIdentityPropagationSettings.Status) | ||
| } | ||
| f5.TrustedIdentityPropagationSettings = f5f4 | ||
| } | ||
| if r.ko.Spec.DomainSettings.UnifiedStudioSettings != nil { |
There was a problem hiding this comment.
does this also not support updates?
There was a problem hiding this comment.
Domain does have an update ops and these settings are part of update ops also
| } | ||
| f5elemf9.InstanceGroups = f5elemf9f1 | ||
| } | ||
| if f5iter.ResourceConfig.InstancePlacementConfig != nil { |
There was a problem hiding this comment.
does this not support updates either?
There was a problem hiding this comment.
HyperParameterTuningJob doesn't have update
| if f5elemf7iter.DataSource.S3DataSource.HubAccessConfig != nil { | ||
| f5elemf7elemf3f1f1 := &svcsdktypes.HubAccessConfig{} | ||
| if f5elemf7iter.DataSource.S3DataSource.HubAccessConfig.HubContentARN != nil { | ||
| f5elemf7elemf3f1f1.HubContentArn = f5elemf7iter.DataSource.S3DataSource.HubAccessConfig.HubContentARN | ||
| } | ||
| f5elemf7elemf3f1.HubAccessConfig = f5elemf7elemf3f1f1 | ||
| } | ||
| if f5elemf7iter.DataSource.S3DataSource.InstanceGroupNames != nil { | ||
| f5elemf7elemf3f1.InstanceGroupNames = aws.ToStringSlice(f5elemf7iter.DataSource.S3DataSource.InstanceGroupNames) | ||
| } | ||
| if f5elemf7iter.DataSource.S3DataSource.ModelAccessConfig != nil { | ||
| f5elemf7elemf3f1f3 := &svcsdktypes.ModelAccessConfig{} | ||
| if f5elemf7iter.DataSource.S3DataSource.ModelAccessConfig.AcceptEula != nil { | ||
| f5elemf7elemf3f1f3.AcceptEula = f5elemf7iter.DataSource.S3DataSource.ModelAccessConfig.AcceptEula | ||
| } | ||
| f5elemf7elemf3f1.ModelAccessConfig = f5elemf7elemf3f1f3 | ||
| } |
There was a problem hiding this comment.
same here, this only has create/delete ops
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm, sirutBuasai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.