Skip to content

initial bootstrap of controller #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

havard024
Copy link

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@havard024 havard024 force-pushed the transfer-controller branch 2 times, most recently from bda59e0 to 589d9d8 Compare May 10, 2025 21:26
@rushmash91
Copy link
Member

rushmash91 commented May 13, 2025

Hi @havard024 , thank you for your contribution!

I think it would be better to separate the generated resource into different PRs. Will make it easier to review. Also, a CRUD test for the Resource.

@havard024
Copy link
Author

Hi @havard024 , thank you for your contribution!

I think it would be better to separate the generated resource from the resource generated into different PRs. Will make it easier to review. Also, a CRUD test for the Resource.

Thanks for looking through, I assume #2 is doing just what you mentioned. In that case, I can close my PR.

Lets see I follow, is the next steps then:

@havard024 havard024 closed this May 21, 2025
@havard024 havard024 force-pushed the transfer-controller branch from 589d9d8 to 3993c89 Compare May 21, 2025 20:35
Copy link

ack-prow bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: havard024

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants