feat: Add amount and attributes name UI validation #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alf-devnull
changed the title
Signed-off-by: Alex Frolov <[email protected]>
alf-devnull
force-pushed
the
feature/custom-host-requirements-improvements
branch
from
72cbcd7 to
85ee595
Compare
|
baxeaz
approved these changes
Dec 30, 2025
Cherie-Chen
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Need to add UI validators for Custom Host Requirement attributes and amounts name fields to give more clear reason why Job is invalid than Pydantic validation errors
What was the solution? (How)
Add UI validators
What is the impact of this change?
User can now see the validation errors in the UI that appears as a tip over the "name" field
How was this change tested?
Have you run a render job successfully with these changes?
Yes
Was this change documented?
Yes
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.