Skip to content

Conversation

@gahyusuh
Copy link
Contributor

What was the problem/requirement? (What/Why)

The VRED sample job bundle could not be submitted using deadline bundle gui-submit due to a validation error:

Job bundle validation failed: Hidden parameters "SequenceName", "name", "description", "input_filenames", "input_directories", "output_directories" are missing values. Hidden parameters must have either a default value in the template or a value in parameter_values.yaml.

This issue arose after enhanced validation for HIDDEN parameters (aws-deadline/deadline-cloud#843) was released with deadline-cloud 0.53.1. The validation now requires that all HIDDEN parameters must have non-empty string default values, but several parameters in the VRED template had empty string defaults.

What was the solution? (How)

  1. Exposed previously hidden parameters to the GUI:

    • Rendering options: IncludeAlphaChannel, OverrideRenderPass, PremultiplyAlpha, TonemapHDR)
    • Job type selection: JobType and SequenceName
  2. Removed unused metadata parameters:

    • Deleted submitter_name, name, description, input_filenames, input_directories, output_directories
    • These parameters were not actually used by the job template logic and served no functional purpose
  3. Kept HIDDEN parameters:

  • JobScriptDir and CondaPackages remain hidden as these parameters already had non-empty default values, so they did not cause validation errors

What is the impact of this change?

Users can now submit a VRED job using this sample template via the GUI submitter (deadline bundle gui-submit) without hitting the validation error.

How was this change tested?

  • Verified that deadline bundle gui-submit vred_render/ opens the GUI without validation errors
  • Tested that all exposed parameters appear correctly in the submission GUI
  • The job rendering was successful.

Was this change documented?

No.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gahyusuh gahyusuh requested a review from a team as a code owner November 12, 2025 20:22
@github-actions github-actions bot added the waiting-on-maintainers Waiting on the maintainers to review. label Nov 12, 2025
@gahyusuh gahyusuh force-pushed the fix_vred_hidden_params branch from adab5ed to 005aded Compare November 12, 2025 22:04
@gahyusuh gahyusuh force-pushed the fix_vred_hidden_params branch from 005aded to 7f43de3 Compare November 12, 2025 23:52
@gahyusuh gahyusuh merged commit d28da06 into aws-deadline:mainline Nov 12, 2025
2 checks passed
@gahyusuh gahyusuh deleted the fix_vred_hidden_params branch November 12, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-maintainers Waiting on the maintainers to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants