fix(vred): expose HIDDEN parameters to GUI and remove unused parameters #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The VRED sample job bundle could not be submitted using
deadline bundle gui-submitdue to a validation error:This issue arose after enhanced validation for
HIDDENparameters (aws-deadline/deadline-cloud#843) was released with deadline-cloud 0.53.1. The validation now requires that allHIDDENparameters must have non-empty string default values, but several parameters in the VRED template had empty string defaults.What was the solution? (How)
Exposed previously hidden parameters to the GUI:
IncludeAlphaChannel,OverrideRenderPass,PremultiplyAlpha,TonemapHDR)JobTypeandSequenceNameRemoved unused metadata parameters:
submitter_name,name,description,input_filenames,input_directories,output_directoriesKept HIDDEN parameters:
JobScriptDirandCondaPackagesremain hidden as these parameters already had non-empty default values, so they did not cause validation errorsWhat is the impact of this change?
Users can now submit a VRED job using this sample template via the GUI submitter (
deadline bundle gui-submit) without hitting the validation error.How was this change tested?
deadline bundle gui-submit vred_render/opens the GUI without validation errorsWas this change documented?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.