fix: move bundle loading button when using gui-submit --browse #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on-maintainers
crowecawcaw
force-pushed
the
bundle
branch
3 times, most recently
from
f4c91ea to
872a41d
Compare
Signed-off-by: Stephen Crowe <[email protected]>
Contributor
Author
|
API changes not actually API changes and safe to ignore. No one should be depending on these imports even if they were not marked as internally only. |
crowecawcaw
changed the title
leongdl
approved these changes
Dec 12, 2025
Contributor
leongdl
left a comment
leongdl
left a comment
There was a problem hiding this comment.
API change was detected, but I don't think it applies in this UI situation.
moorec-aws
approved these changes
Dec 29, 2025
moorec-aws
removed
the
waiting-on-maintainers
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
When using
deadline bundle gui-submit --browse, there's an awkward button under job specific settings to swap job bundles. It looks weird.The option was added a couple years ago in this PR: #35
What was the solution? (How)
Move the button to the bottom of the window next to the "Export bundle" button.
What is the impact of this change?
Cleaner bundle submitter.
How was this change tested?
Ran the command, saw the button was moved. Added unit tets
Was this change documented?
n/a
Does this PR introduce new dependencies?
No
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.