Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run contract tests with no cache #739

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vasireddy99
Copy link
Contributor

Description of changes:

Currently contract tests are cached on main-build, this pr changes to run on no cache

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vasireddy99 vasireddy99 requested a review from a team as a code owner February 3, 2024 06:55
@codecov-commenter
Copy link

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (09e6487) 85.71% compared to head (92e8e4b) 50.73%.
Report is 234 commits behind head on main.

Files Patch % Lines
...ent/providers/AwsAppSignalsCustomizerProvider.java 24.00% 35 Missing and 3 partials ⚠️
...gent/providers/AwsSpanMetricsProcessorBuilder.java 0.00% 20 Missing ⚠️
...ders/AttributePropagatingSpanProcessorBuilder.java 0.00% 16 Missing ⚠️
...viders/AwsMetricAttributesSpanExporterBuilder.java 0.00% 11 Missing ⚠️
...try/javaagent/providers/AwsSpanProcessingUtil.java 90.16% 1 Missing and 5 partials ⚠️
...vaagent/providers/AwsMetricAttributeGenerator.java 96.89% 2 Missing and 3 partials ⚠️
...y/javaagent/providers/AwsSpanMetricsProcessor.java 91.48% 0 Missing and 4 partials ⚠️
...t/providers/AttributePropagatingSpanProcessor.java 94.59% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##               main     #739       +/-   ##
=============================================
- Coverage     85.71%   50.73%   -34.99%     
- Complexity       19      264      +245     
=============================================
  Files             3       39       +36     
  Lines            49     1301     +1252     
  Branches          5      141      +136     
=============================================
+ Hits             42      660      +618     
- Misses            3      609      +606     
- Partials          4       32       +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryan-aguilar
Copy link
Contributor

Why is this necessary?

@vasireddy99
Copy link
Contributor Author

vasireddy99 commented Feb 28, 2024

Why is this necessary?

In one of the workflows the contract tests are cached and it didn't run, this makes sure that we run contract tests neverthless.

Copy link

This PR is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the stale label Apr 28, 2024
@thpierce thpierce requested a review from a team as a code owner August 29, 2024 19:36
@github-actions github-actions bot removed the stale label Sep 1, 2024
Copy link

github-actions bot commented Nov 3, 2024

This PR is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the stale label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants