-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.32.5 #941
Merged
bjrara
merged 8 commits into
aws-observability:release/v1.32.x
from
bjrara:release/v1.32.x
Oct 31, 2024
Merged
Release v1.32.5 #941
bjrara
merged 8 commits into
aws-observability:release/v1.32.x
from
bjrara:release/v1.32.x
Oct 31, 2024
+246
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Description of changes:* Final step of MCM: https://mcm.amazon.dev/cms/MCM-112315558/execution/step/e035bb70-e64d-4aee-a26f-ac4c2c11c029 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Update Dockerfile to use public ECR image *Issue #, if available:* *Description of changes:* Update Dockerfile to use public ECR image By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Merging release/v1.32.4 into main as part of MCM: https://mcm.amazon.dev/cms/MCM-112315558/execution/step/9de5087f-2c46-42b8-b760-a9ce99b569df By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
*Issue #, if available:* *Description of changes:* Update Dockerfile to use public ECR image By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
## Feature request Add runtime metrics collection into Application Signals. ## Description of changes: This PR is an umbrella PR to track the ongoing changes for runtime metrics. 1. [Add Application Signals runtime metrics with feature disabled aws-observability#900](aws-observability#900) [Merged in main] 2. [feat: Add contract tests for runtime metrics aws-observability#893](aws-observability#893) 3. Enable runtime metrics by default By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. *Issue #, if available:* *Description of changes:* By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Reno Seo <[email protected]>
*Issue #, if available:* E2E Operator test is currently failing due to a known issue. We do not have an immediate plan to fix it so commenting it out for now. Example failed run: https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/11525535146/job/32241628521 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
…y#939) *Issue #, if available:* Main-build Enablement E2E tests started failing starting from this [PR](aws-observability#899). It was due to the usage of `isEmpty()` for Optional datatypes, which is available only from Java 11 *Description of changes:* Change .isEmpty() to .isPresent() for optional types By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: Min Xia <[email protected]>
vastin
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.