-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding UdpExporter for Otlp spans #944
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrara
reviewed
Nov 5, 2024
...der/src/main/java/software/amazon/opentelemetry/javaagent/providers/OtlpUdpSpanExporter.java
Outdated
Show resolved
Hide resolved
...der/src/main/java/software/amazon/opentelemetry/javaagent/providers/OtlpUdpSpanExporter.java
Outdated
Show resolved
Hide resolved
...der/src/main/java/software/amazon/opentelemetry/javaagent/providers/OtlpUdpSpanExporter.java
Outdated
Show resolved
Hide resolved
awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/UdpSender.java
Outdated
Show resolved
Hide resolved
awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/UdpSender.java
Outdated
Show resolved
Hide resolved
bjrara
reviewed
Nov 5, 2024
...der/src/main/java/software/amazon/opentelemetry/javaagent/providers/OtlpUdpSpanExporter.java
Outdated
Show resolved
Hide resolved
...rovider/src/test/java/software/amazon/opentelemetry/javaagent/providers/UdpExporterTest.java
Show resolved
Hide resolved
bjrara
reviewed
Nov 5, 2024
awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/UdpSender.java
Show resolved
Hide resolved
...der/src/main/java/software/amazon/opentelemetry/javaagent/providers/OtlpUdpSpanExporter.java
Outdated
Show resolved
Hide resolved
...der/src/main/java/software/amazon/opentelemetry/javaagent/providers/OtlpUdpSpanExporter.java
Outdated
Show resolved
Hide resolved
wangzlei
previously approved these changes
Nov 6, 2024
bjrara
reviewed
Nov 6, 2024
awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/UdpSender.java
Show resolved
Hide resolved
bjrara
approved these changes
Nov 6, 2024
The trivy image scan failure causing CI to fail is due to this issue: aquasecurity/trivy-action#389 |
Had to override the checks and merge due to trivy scan issue mentioned above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adding a new
SpanExporter
that can export spans to a configurable endpoint over UDP.T1S
orT1U
(depending on sampled), and finally appended to the{"format":"json","version":1}\n
string before being exported to the endpoint, default is127.0.0.1:2000
.Testing:
Wrote a test to create and export a real span via X-Ray Daemon running locally.
Unit test
Observed trace data in X-Ray service
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.