Skip to content

Conversation

@ezhang6811
Copy link
Contributor

@ezhang6811 ezhang6811 commented Sep 23, 2025

Issue #, if available:

Description of changes:
Add a workflow nightly-build.yml with following actions:

  • creates or checks out existing nightly-dependency-updates branch
  • checks for newest versions of dependencies in opentelemetry-python and opentelemetry-python-contrib, bumps versions if applicable, and creates/updates PR
  • search for releases with breaking changes in release notes, and links in the PR
  • runs main build checks on the branch, publishes a failure metric based on the outcome.

Example nightly build PR: #526

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ezhang6811 ezhang6811 requested a review from a team as a code owner September 23, 2025 01:59
@ezhang6811 ezhang6811 added the skip changelog doesn't need a CHANGELOG entry label Sep 23, 2025
@ezhang6811
Copy link
Contributor Author

I just realized: I updated main build so that it also triggers when pushes are made to the nightly-dependency-updates branch so that updates to the nightly build PR can trigger main build again. If this is the case, do we even need to run main build in the nightly build workflow itself, or is that redundant?

Copy link
Contributor

@thpierce thpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a complete review, just some initial thoughts.

Comment on lines 99 to 102
- OpenTelemetry Python: ${{ steps.get_versions.outputs.otel_python_version }}
- OpenTelemetry Contrib: ${{ steps.get_versions.outputs.otel_contrib_version }}
- [opentelemetry-sdk-extension-aws](https://pypi.org/project/opentelemetry-sdk-extension-aws/${{ steps.get_versions.outputs.opentelemetry_sdk_extension_aws_version }}/): ${{ steps.get_versions.outputs.opentelemetry_sdk_extension_aws_version }}
- [opentelemetry-propagator-aws-xray](https://pypi.org/project/opentelemetry-propagator-aws-xray/${{ steps.get_versions.outputs.opentelemetry_propagator_aws_xray_version }}/): ${{ steps.get_versions.outputs.opentelemetry_propagator_aws_xray_version }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add links to OpenTelemetry Python/Contrib?

print("Error: OTEL_PYTHON_VERSION and OTEL_CONTRIB_VERSION environment variables required")
sys.exit(1)

pyproject_path = "aws-opentelemetry-distro/pyproject.toml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wrong about contract tests, we do need it for mock-collector.

For aws-otel-python-instrumentation/lambda-layer/src/tests/requirements.txt - reach out to @wangzlei to confirm if these should be kept up to date. We can do this as a backlog item though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, new job update-pr should always() run, but we should include the status of main-build run in the PR. It's easier to work with the PRs that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog doesn't need a CHANGELOG entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants