-
Notifications
You must be signed in to change notification settings - Fork 27
Add nightly dependency bump workflow #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add nightly dependency bump workflow #479
Conversation
|
I just realized: I updated main build so that it also triggers when pushes are made to the |
This reverts commit 076e529.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a complete review, just some initial thoughts.
| - OpenTelemetry Python: ${{ steps.get_versions.outputs.otel_python_version }} | ||
| - OpenTelemetry Contrib: ${{ steps.get_versions.outputs.otel_contrib_version }} | ||
| - [opentelemetry-sdk-extension-aws](https://pypi.org/project/opentelemetry-sdk-extension-aws/${{ steps.get_versions.outputs.opentelemetry_sdk_extension_aws_version }}/): ${{ steps.get_versions.outputs.opentelemetry_sdk_extension_aws_version }} | ||
| - [opentelemetry-propagator-aws-xray](https://pypi.org/project/opentelemetry-propagator-aws-xray/${{ steps.get_versions.outputs.opentelemetry_propagator_aws_xray_version }}/): ${{ steps.get_versions.outputs.opentelemetry_propagator_aws_xray_version }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add links to OpenTelemetry Python/Contrib?
| print("Error: OTEL_PYTHON_VERSION and OTEL_CONTRIB_VERSION environment variables required") | ||
| sys.exit(1) | ||
|
|
||
| pyproject_path = "aws-opentelemetry-distro/pyproject.toml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wrong about contract tests, we do need it for mock-collector.
For aws-otel-python-instrumentation/lambda-layer/src/tests/requirements.txt - reach out to @wangzlei to confirm if these should be kept up to date. We can do this as a backlog item though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, new job update-pr should always() run, but we should include the status of main-build run in the PR. It's easier to work with the PRs that way.
Issue #, if available:
Description of changes:
Add a workflow
nightly-build.ymlwith following actions:nightly-dependency-updatesbranchExample nightly build PR: #526
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.