-
Notifications
You must be signed in to change notification settings - Fork 92
chore(ci): Add GraalVM E2E tests and GH workflows #1945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rics configuration be in parent pom.
I don't understand why the osv-scanner fails since this vulnerability was not introduced by this PR. According to the docs it should only scan the PR diff. https://google.github.io/osv-scanner/github-action/#scan-on-pull-request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @phipag great job! Some few comments to address before we merge it.
powertools-e2e-tests/src/test/java/software/amazon/lambda/powertools/MetricsE2ET.java
Show resolved
Hide resolved
|
Thanks for your feedback @leandrodamascena, I addressed your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all the comments @phipag! Ship it!
Approved!
Summary
This PR introduces E2E tests for testing against native images deployed on
AL2023.provided
runtime compiled using GraalVM.It is important to have these tests to cover regressions of future code changes. For example, if the GraalVM metadata files were not updated inline with new code changes. We want to protect customers from releasing changes that break GraalVM compatibility.
Tests pass ✅
Changes
The GraalVM E2E tests are triggered by a custom
e2e-graal
maven profile which sets a System Propertygraalvm.enabled = true
. This will be read within the E2E infrastructure logic to decide whether to deploy a native image on the Lambda provided runtime or not. The E2E test assertions themselves stay untouched because we expect the exact same output for native images like for JVM based Lambda handlers. We can include more utilities in GraalVM E2E tests as we grow the GraalVM support across more Powertools utilities by updating this maven profile configuration.e2e-graal
job running the same Java matrix and same workflows likee2e
DockerConfiguration.java
to hold configuration for CDK Bundling within Docker. Required for x86 cross-compilation of native image.Issue number: #1803
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.