-
Notifications
You must be signed in to change notification settings - Fork 168
improv(ci): removed the secret inheritance and replaced with the needed secrets #4364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
624d3e7
to
9fd379b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably use a more descriptive name though than TOKEN – TOKEN_GITHUB maybe
460adbd
to
21a7be4
Compare
21a7be4
to
40342ff
Compare
|
@dreamorosi I think it's because we need to pass in the correct environment for this. Do you know which environment these secrets are scoped to? |
Should be |
@dreamorosi I tried adding the environment there, but the linter then complains that the property is not allowed. It seems like when using reusable workflows, we don't define the environments in the calling workflow. Maybe the warning is because of this issue with the extension and is a false positive? |
Summary
This PR replaces the places where a secret was inherited to a reusable workflow and instead passes the secrets that are only required which was flagged by SonarQube.
Changes
Changed the workflows which call a reusable workflow to not inherit all the secrets and passed the secrets which are only required.
Issue number: closes #4363
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.