Skip to content

fix(security): enforce HTTPS-only S3 access [rs3] #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jalawala wants to merge 1 commit into
base: rs3
Choose a base branch
from
Open

fix(security): enforce HTTPS-only S3 access [rs3] #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion static/inspector-codepipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,24 @@ Resources:
CodePipelineArtifactBucket:
Type: AWS::S3::Bucket

CodePipelineArtifactBucketPolicy:
Type: AWS::S3::BucketPolicy
Properties:
Bucket: !Ref CodePipelineArtifactBucket
PolicyDocument:
Version: 2012-10-17
Statement:
- Sid: DenyInsecureConnections
Effect: Deny
Principal: "*"
Action: s3:*
Resource:
- !GetAtt CodePipelineArtifactBucket.Arn
- !Join ["", [!GetAtt CodePipelineArtifactBucket.Arn, "/*"]]
Condition:
Bool:
aws:SecureTransport: false

ContainerComponentsRepo:
Type: AWS::CodeCommit::Repository
Properties:
Expand Down Expand Up @@ -171,7 +189,8 @@ Resources:
Principal: "*"
Action: s3:*
Resource:
!Join ["", [!GetAtt CodePipelineArtifactStoreBucket.Arn, "/*"]]
- !GetAtt CodePipelineArtifactStoreBucket.Arn
- !Join ["", [!GetAtt CodePipelineArtifactStoreBucket.Arn, "/*"]]
Condition:
Bool:
aws:SecureTransport: false
Expand Down