fix(security): enforce HTTPS-only S3 access [improve-startup] - #68
Open
jalawala wants to merge 1 commit into
Open
fix(security): enforce HTTPS-only S3 access [improve-startup]#68jalawala wants to merge 1 commit into
jalawala wants to merge 1 commit into
Conversation
Resolves AppSec finding acat-cfnlint.EA013 (S3 bucket policy allows non-secure transport) in static/inspector-codepipeline.yaml: - CodePipelineArtifactStoreBucketPolicy: extend DenyInsecureConnections to cover the bucket-level ARN in addition to bucket/* (object) ARN, so bucket-level calls over HTTP are also denied. - CodePipelineArtifactBucket: add a new bucket policy with an equivalent aws:SecureTransport=false deny; it previously had no policy at all. Ticket: V2268145424
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodePipelineArtifactBucket(previously had no policy)DenyInsecureConnectionsonCodePipelineArtifactStoreBucketPolicyto cover both bucket and object ARNsTicket
Resolves V2268145424 — "S3 bucket policy allows non-secure transport"
Test plan