Fixes #31
Open
Fixes #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et changed. Add comments and examples about managing multiple regions and the main region.
…r: zip -r cfct-aws-ct-vpc-flowlogs.zip manifest.yaml templates/
…ault s3 bucket settings.
wellsiau-aws
added
bug
|
@batzel , thank you for opening the pull request. I have assigned myself to review this. However, please expect delay in my response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #25 fix, Look at AWSControlTowerBP-BASELINE-CLOUDWATCH since cloudtrail stackset changed.
Added some comments to manifest.yaml to clarify multi-region deployment options.
Updated bucket policy to make it non-Public so it works with newer default s3 bucket settings.
Changed the bucket policy to allow accounts to see and read only data that account had logged. (Previously let any account read all flowlogs in the organization.)
Moved management_prep.template out of templates/ to make zipping easier: zip -r cfct-aws-ct-vpc-flowlogs.zip manifest.yaml templates/
The bucket policy was being refused with an "Access Denied" which turned out to be because the policy didn't lock the logging service down to being in the source organization.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.