Add tag for cost management #1167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuhitogo
commented
Jul 6, 2025
| @@ -6,4 +6,7 @@ import { createStacks } from '../lib/create-stacks'; | |||
|
|
|||
| const app = new cdk.App(); | |||
| const params = getParams(app); | |||
| if (params.tag?.key && params.tag?.value) { | |||
| cdk.Tags.of(app).add(params.tag.key, params.tag.value); | |||
There was a problem hiding this comment.
KnowledgeBase を有効化していた場合にタグを新たにつけると破壊的変更になってしまうため、タグ無しの場合はタグをつけないように修正
kazuhitogo
commented
Jul 6, 2025
| // NOTE: InvokeModelWithBidirectionalStreamCommand currently does not support Inference Profile Arn. | ||
| // When AWS adds support, uncomment the code block below and change 'const' to 'let' for modelIdOrArn. | ||
|
|
||
| const modelIdOrArn = event.model.modelId; // Fallback to modelId for now |
There was a problem hiding this comment.
InvokeModelWithBidirectionalStreamCommand が Inference Profile Arn (タグ) は対応していないが将来的な対応及び他との実装に合わせるため
kazuhitogo
commented
Jul 6, 2025
| for (const modelId of modelIds) { | ||
| // Inference Profile is not supported Cross Region Inference | ||
| if ( | ||
| modelId.region === currentRegion && |
There was a problem hiding this comment.
cross region inference は inference profile を2025/7/6 時点作成できないため
kazuhitogo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Apply an Application Inference Profile to Bedrock models to tag model inferences.
Also apply tags to the entire CDK asset
Checklist
npm run cdk:testand if there are snapshot differences, executenpm run cdk:test:update-snapshotto update snapshotsRelated Issues
#702 #650