fix(agent): validate AWS credentials before Docker build#33
Merged
krokoko merged 2 commits intoaws-samples:mainfrom Apr 15, 2026
Merged
Conversation
Move credential resolution (explicit env vars, AWS CLI/SSO, ~/.aws mount) before the Docker image build so expired sessions and missing credentials fail immediately with actionable guidance. - Fix unbound variable crash with empty array under set -u - Remove dead MOUNT_AWS_DIR variable - Expand error message to list all three credential methods - Update local testing docs with credential resolution details, troubleshooting table, and Starlight admonitions
krokoko
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move credential resolution (explicit env vars, AWS CLI/SSO, ~/.aws mount) before the Docker image build so expired sessions and missing credentials fail immediately with actionable guidance.
Area
cdk— infrastructure, handlers, constructsagent— Python runtime / Docker imagecli—bgagentclientdocs— guides or design sources (docs/guides/,docs/design/)tooling— rootmise.toml, scripts, CI workflowsTip: AGENTS.md lists where to edit and which tests to extend.
Related
Changes
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.